Add server/config package.#320
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration schema for the Bootz server, including Protobuf definitions, Bazel build rules, and generated Go code. The review feedback focuses on improving the Protobuf design and ensuring consistent Go package naming. Specifically, it is recommended to use the bytes type instead of Base64-encoded strings for binary data like certificates and keys to be more idiomatic and efficient. Additionally, the reviewer suggested adding option go_package to the proto file and updating the Bazel importpath to ensure the generated Go package name correctly reflects the intended structure.
f673437 to
7ef981f
Compare
|
Is this for Monax? If so, I would like to see how this fits in with the existing protos or proposed workflow. Do you have any example configs for this? |
Yes, this is for Monax, so the vendors can use all real data like ownership_voucher. |
In that case, could you either edit the existing Monax protos under server/tests/proto or move the config there? The reason I ask is because this file is very similar to server/tests/proto/test.proto |
Besides Monax, this proto definition will be referenced by Even without doing any test (Monax or not), this proto definition is still required. |
I'm not sure how this config proto will be used in the production (non-test instance). Doesn't this config have to contain an exhaustive list of the inventory and other artifacts? In the real world, we fetch these from external systems. |
This config profo is only for the open source Bootz. This config proto itself as well as its consumers: Our internal Bootz will use a different version of |
I have created another PR of |
|
I think we can put Monax aside for now, because we are still too far away from implementing any Monax test. The major use of this I will remove all those command line arguments and only use a single textproto file generated from this The How we should start the Monax Bootz test can be discussed later and doesn't have to use this I hope my explanation makes things a little clearer now. |
No description provided.